Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clusters set auto_cores max #3778

Merged
merged 8 commits into from
Sep 19, 2024
Merged

Clusters set auto_cores max #3778

merged 8 commits into from
Sep 19, 2024

Conversation

ashton22305
Copy link
Contributor

Work on #3755

@johrstrom
Copy link
Contributor

Looks like tests are failing because we didn't stub sinfo.

You can take a look here on how we stub scontrol to get partitions.

def stub_scontrol
['owens', 'oakley'].each do |cluster|
Open3
.stubs(:capture3)
.with({}, 'scontrol', 'show', 'part', '-o', '-M', cluster.to_s, stdin_data: '')
.returns([File.read("test/fixtures/cmd_output/scontrol_show_partitions_#{cluster}.txt"), '', exit_success])
end
end

Copy link
Contributor

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@johrstrom johrstrom merged commit c32048e into master Sep 19, 2024
26 checks passed
@johrstrom johrstrom deleted the auto-cores-max branch December 2, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants