Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sanitize template paths #3775

Closed
wants to merge 2 commits into from
Closed

sanitize template paths #3775

wants to merge 2 commits into from

Conversation

johrstrom
Copy link
Contributor

sanitize template paths based off of ActiveStorage::Filename#sanitized because we can't (or at least don't) use the activestorage gem.

@johrstrom
Copy link
Contributor Author

I am remembering now why this won't work. ActiveStorage::Filename#sanitized is for a filename, not a full path. So replacing / with - on a full path absolutely destroys the path, so we can't sanitize the full path, we could only the filename.

@johrstrom johrstrom closed this Sep 5, 2024
@johrstrom johrstrom deleted the sanitize-project-paths branch September 5, 2024 15:34
@johrstrom johrstrom restored the sanitize-project-paths branch September 5, 2024 15:34
@johrstrom johrstrom deleted the sanitize-project-paths branch September 5, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component/dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johrstrom @osc-bot