Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More launcher id checks #3774

Merged
merged 4 commits into from
Sep 11, 2024
Merged

More launcher id checks #3774

merged 4 commits into from
Sep 11, 2024

Conversation

johrstrom
Copy link
Contributor

More launcher id checks to get a handle on the codeql alerts.

While this doesn't satisfy the codeql alerts - I'm happy with it after some time. CodeQl would have us sanitize a bad value. I don't think we want to sanitize a bad value, I think we just want to force a good value if the value given is incorrect.

So this sets @id once and only once and makes a last minute check in save to be sure it's still correct (there's a test case that sets the instance variable and still tries to save).

Copy link
Contributor

@Oglopf Oglopf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@johrstrom johrstrom merged commit f97dafd into master Sep 11, 2024
26 checks passed
@johrstrom johrstrom deleted the more-launcher-id-checks branch September 11, 2024 20:19
ashton22305 pushed a commit that referenced this pull request Sep 19, 2024
Only set launcher @id once and check against regex and add some more checks when saving.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants