Fix FontAwesome icon width in navbar app icons #3075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FontAwesome defines .fa-fw to have width 1.25em. With the previous 1/1 ratio, the icon flows over to the text to the right. Use margin-right for other icons to align.
johrstrom
approved these changes
Sep 27, 2023
|
Sorry as soon as I saw your images I recognized that 14px. Why not modify this? ondemand/apps/dashboard/app/javascript/stylesheets/apps.scss Lines 36 to 40 in a4034c0 |
Modifying that affects the non-FA images too. Changing the width there makes the other app icons stretched out, although it is not too noticeable since they are so small. |
johrstrom
approved these changes
Sep 27, 2023
abujeda
added a commit
to hmdc/ondemand
that referenced
this pull request
Feb 14, 2024
johrstrom
pushed a commit
that referenced
this pull request
Feb 14, 2024
johrstrom
pushed a commit
that referenced
this pull request
Feb 26, 2024
jgoodson
pushed a commit
to jgoodson/ondemand
that referenced
this pull request
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently some of the FontAwesome icons flow over the fixed width that is set for the icons. Visible in the screenshot here:
This PR sets the proper width for FA icons, while keeping the size the same:
This happens since FA sets the width of
.fa-fwto1.25em. I addedmargin-rightto non-FA icons to align app names properly, although another option would be to set width (and height) to1.25emfor those, but that would affect the size or aspect ratio of them.