expose bc_dynamic_js to javascript so we can always load these files #3058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johrstrom
commented
Sep 19, 2023
Comment on lines
-719
to
-729
| // simple function to sanitize css query strings | ||
| function sanitizeQuery(item) { | ||
| return item.replaceAll('.', '\\.'); | ||
| } | ||
|
|
||
|
|
||
| function optionForEvent(target) { | ||
| let simpleName = shortId(target['id']); | ||
| return mountainCaseWords(simpleName); | ||
| }; | ||
|
|
There was a problem hiding this comment.
These removes (and the one above) aren't really a part of this pull request - I just noticed in my linter that they're unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2950 so that the javascript file (with path_selector and other updates) will get loaded all the time. Only when
bc_dynamic_jsis enabled (the config now exposed through javascript) will the javascript file create event handlers for the same.