Add test and logic to set default icon (#2583)

OSC · Feb 16, 2023 · b6cedd0 · b6cedd0
1 parent aae8336
commit b6cedd0
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/apps/dashboard/app/models/project.rb b/apps/dashboard/app/models/project.rb
@@ -100,12 +100,16 @@ def manifest_path
   def valid_form_inputs?(attributes)
     icon_pattern = %r{\Afa[bsrl]://[\w-]+\z}
     name_pattern = /\A[\w-]+\z/
+
     if !attributes[:icon].nil? && !attributes[:icon].match?(icon_pattern)
       errors.add(:icon, :invalid_format, message: 'Icon format invalid or missing')
       false
     elsif !attributes[:name].match?(name_pattern)
       errors.add(:name, :invalid_format, message: 'Name format invalid')
       false
+    elsif attributes[:icon].nil?
+      attributes[:icon] = 'fas://cog'
+      true
     else
       true
     end

diff --git a/apps/dashboard/test/models/projects_test.rb b/apps/dashboard/test/models/projects_test.rb
@@ -141,4 +141,24 @@ class ProjectsTest < ActiveSupport::TestCase
       assert_equal expected_manifest_yml, File.read(project.manifest_path.to_s)
     end
   end
+
+  test 'icon defaults to fas://cog' do
+    Dir.mktmpdir do |tmp|
+      project_path = Pathname.new(tmp)
+      OodAppkit.stubs(:dataroot).returns(project_path)
+      attrs = { name: 'test-project', description: 'test description' }
+
+      project = Project.new(attrs)
+      project.save(attrs)
+
+      manifest_yml = <<~HEREDOC
+        ---
+        name: test-project
+        description: test description
+        icon: fas://cog
+      HEREDOC
+
+      assert_equal manifest_yml, File.read(project.manifest_path.to_s)
+    end
+  end
 end