Module active jobs (#3957)

import active_jobs js as a module and add the ability to minify js in dev environment.
OSC · Nov 18, 2024 · 4f7a643 · 4f7a643
1 parent 0fe6743
commit 4f7a643
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/apps/dashboard/app/views/active_jobs/index.html.erb b/apps/dashboard/app/views/active_jobs/index.html.erb
@@ -68,4 +68,4 @@
 >
 </div>
 
-<%=  javascript_include_tag 'active_jobs', nonce: true %>
+<%=  javascript_include_tag 'active_jobs', nonce: true, type: 'module' %>
diff --git a/apps/dashboard/esbuild.config.js b/apps/dashboard/esbuild.config.js
@@ -73,7 +73,7 @@ esbuild.build({
   outdir: buildDir,
   external: ['fs'],
   plugins: [prepPlugin, minifiedSrcResolvePlugin],
-  minify: process.env.RAILS_ENV == 'production' ? true : false,
+  minify: process.env.RAILS_ENV == 'production' || process.env.MINIFY == 'false' ? true : false,
 }).catch((e) => { 
   console.error(e.message);
   process.exit(1);
-Original file line number
+Diff line change
@@ Expand Up / @@ -68,4 +68,4 @@ @@
     >
     </div>
-    <%=  javascript_include_tag 'active_jobs', nonce: true %>
+    <%=  javascript_include_tag 'active_jobs', nonce: true, type: 'module' %>