Skip to content

Commit

Permalink
Add buildx back, didn't solve parallel docker build issues
Browse files Browse the repository at this point in the history
  • Loading branch information
treydock committed Nov 9, 2024
1 parent f0fca59 commit 934167c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion lib/ood_packaging/build_box.rb
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ def scripts

def build_command
if container_runtime == 'docker'
['build']
['buildx', 'build']
else
['build']
end
Expand Down
6 changes: 3 additions & 3 deletions spec/ood_packaging/build_box_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
context 'when building for el8' do
it 'executes el8 build command' do
expected_cmd = [
'docker build', '--platform linux/amd64',
'docker buildx build', '--platform linux/amd64',
"--tag ohiosupercomputer/ood-buildbox-el8-x86_64:#{OodPackaging::VERSION}",
'--output', 'type=docker', '-f /tmp/dockerfile /fake-builddir'
]
Expand All @@ -41,7 +41,7 @@

it 'executes ubuntu-20.04 build command' do
expected_cmd = [
'docker build', '--platform linux/amd64',
'docker buildx build', '--platform linux/amd64',
"--tag ohiosupercomputer/ood-buildbox-ubuntu-20.04-x86_64:#{OodPackaging::VERSION}",
'--output', 'type=docker', '-f /tmp/dockerfile /fake-builddir'
]
Expand All @@ -55,7 +55,7 @@

it 'executes aarch64 build command' do
expected_cmd = [
'docker build', '--platform linux/arm64',
'docker buildx build', '--platform linux/arm64',
"--tag ohiosupercomputer/ood-buildbox-el8-aarch64:#{OodPackaging::VERSION}",
'--output', 'type=docker', '-f /tmp/dockerfile /fake-builddir'
]
Expand Down

0 comments on commit 934167c

Please sign in to comment.