Fixed using of deprecated API. Now strapping is compatible with mediawiki 1.27 #66
Conversation
| @@ -49,7 +49,7 @@ You can see a (customized) instance of Strapping in action by visiting http://oV | |||
| 2. Clone the repository: | |||
|
|
|||
| ``` | |||
| git clone https://github.com/OSAS/strapping-mediawiki strapping | |||
| git clone https://github.com/axxie/strapping-mediawiki strapping | |||
There was a problem hiding this comment.
Are you sure you want https://github.com/OSAS/strapping-mediawiki to link to axxie?
Thank you for working on strapping-mediawiki!
There was a problem hiding this comment.
Hm...., that's strange.
I edited the README.md after creating pull request. I thought the change will not be included.
Anyway, no, I definitely don't want to change that line in your branch.
There was a problem hiding this comment.
I reverted that change, now README.md can be merged as well.
There was a problem hiding this comment.
@axxie for future reference, that's a feature of github: if you edit a branch from which you created a PR, the PR is automatically updated. (You should see the message "Add more commits by pushing to the master branch on axxie/strapping-mediawiki" at the bottom of this page.)
There was a problem hiding this comment.
axxie:
I definitely don't want to change that line in your branch.
Btw not "my" branch. I am just a user / github 'watcher' of this project.
There was a problem hiding this comment.
Uh, I see.
Looks like original author, @garrett, abandoned the project long time ago.
There was a problem hiding this comment.
axxie:
Looks like original author, @garrett, abandoned the project long time ago.
I am wondering about that also. Not sure. They are still using it:
Perhaps he is busy. Perhaps it works good enough for him so he only
reacts to and merges stuff that is of personal interest to him.
Do you plan to fork and maintain strapping-mediawiki? @axxie
There was a problem hiding this comment.
I plan the following:
- fix some minor bug
- update skin to bootstrap 3
Mediawiki developers declared userIsWatching() as deprecated in 1.20 and completely removed in 1.27.
The proposed change fixes using of the removed API.