Skip to content
This repository has been archived by the owner on Aug 22, 2019. It is now read-only.

Commit

Permalink
Check for $content using isset() instead of ! (issue #31)
Browse files Browse the repository at this point in the history
  • Loading branch information
@garrett
garrett committed Jun 13, 2013
1 parent 018aac7 commit 1d2e2d2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Strapping.skin.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -673,7 +673,7 @@ private function renderNavigation( $elements ) {

case 'SIDEBAR':
foreach ( $this->data['sidebar'] as $name => $content ) {
if ( !$content ) {
if ( isset($content) ) {
continue;
}
if ( in_array( $name, $wgStrappingSkinSidebarItemsInNavbar ) ) {
Expand Down

2 comments on commit 1d2e2d2

@threadflow
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the code should be !isset($content).

@garrett
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. You're right. (All this mucking about in IE is getting to me.)

Please sign in to comment.