-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add heat transfer #108
base: main
Are you sure you want to change the base?
Add heat transfer #108
Conversation
// ==================================================== | ||
// Boundary condition | ||
// ==================================================== | ||
// EXAMPLE 1: Temperature profile imposed over entire domain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to remove some of this before merging
double thermal_coeff; | ||
double kappa; | ||
double cp; | ||
bool constant_conductivity; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this refers to the "micro-conductivity"? Perhaps call it "constant_microconductivity"?
|
||
BaseDynamicTemperatureModel( const double _delta, const double _kappa, | ||
const double _cp, | ||
const bool _constant_conductivity = true ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do we do if we want a different micro-conductivity than the constant one?
kappa = _kappa; | ||
cp = _cp; | ||
const double d3 = _delta * _delta * _delta; | ||
thermal_coeff = 9.0 / 2.0 * _kappa / pi / d3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be analogous to Line 52 in CabanaPD_ForceModels_PMB.hpp. I was wondering if we should use a more clear description. There, we used "c". However using "k" may not be good.
constant_conductivity = _constant_conductivity; | ||
} | ||
|
||
KOKKOS_INLINE_FUNCTION double conductivity_function( double r ) const |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the function be called "microconductivity_function"?
} | ||
|
||
template <class ParticleType> | ||
void stepEuler( const ParticleType& particles, const double dt ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note we are using "forward" Euler
|
||
const double coeff = | ||
model.thermal_coeff * model.conductivity_function( xi ); | ||
conduction( i ) += |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is conduction(i) initialized? Is this in Line 111: Cabana::deep_copy( conduction, 0.0 ); ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's correct
The difference between the critical time step of heat transfer and mechanics requires: |
20807aa
to
ffdbe3b
Compare
Includes various b.c. options
ffdbe3b
to
9571abf
Compare
Adds new heat transfer capability; part of #110
New example copies existing thermal deformation example