Skip to content
This repository has been archived by the owner on Nov 27, 2024. It is now read-only.

mat + sparsity: use dset.layout_vec.local_size for sizes #714

Merged
merged 1 commit into from
Jan 9, 2024
Merged

mat + sparsity: use dset.layout_vec.local_size for sizes #714

merged 1 commit into from
Jan 9, 2024

Conversation

ksagiyam
Copy link
Contributor

@ksagiyam ksagiyam commented Jan 8, 2024 •
edited
Loading

Make Mat and Sparsity inherit sizes from dset.layout_vec.

Firedrake test: firedrakeproject/firedrake#3311

@ksagiyam ksagiyam marked this pull request as draft January 8, 2024 23:45
@ksagiyam ksagiyam mentioned this pull request Jan 8, 2024
Closed
connorjward
connorjward approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@connorjward connorjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much cleaner.

@ksagiyam ksagiyam marked this pull request as ready for review January 9, 2024 15:06
@ksagiyam
Copy link
Contributor Author

ksagiyam commented Jan 9, 2024

Thanks, Connor. Can we merge this?

@connorjward connorjward merged commit fbde61f into master Jan 9, 2024
4 checks passed
@connorjward connorjward deleted the ksagiyam/use_layout_vec_local_size branch January 9, 2024 15:12
@ksagiyam ksagiyam mentioned this pull request Jan 9, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@connorjward connorjward connorjward approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksagiyam @connorjward