-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/hdf5 compile #218
base: release/2020
Are you sure you want to change the base?
Fix/hdf5 compile #218
Conversation
@bozbez this should be useful for the new build system too |
Shall I close this and delete branch? Seems like Joe is handling this. |
I think we were discussing moving out the current state of the master branch into a release branch for the current Hydra iteration - in that case then this patch may still be useful for that branch, so perhaps leave it open for now and we can point it at |
Yes, leave this for now. Will be useful for the current OP2-Hydra. |
I think this is fine as a fix but as a note the HDF5 support for the MPI variants gets compiled into In the |
Turns out parallel-HDF5 does need a MPI compiler, but not serial. So Makefile needs to check whether HDF5 is serial or parallel, if we want to maintain a functional MPI-free build path.