Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/hdf5 compile #218

Open
wants to merge 3 commits into
base: release/2020
Choose a base branch
from
Open

Fix/hdf5 compile #218

wants to merge 3 commits into from

Conversation

aowenson
Copy link
Collaborator

Turns out parallel-HDF5 does need a MPI compiler, but not serial. So Makefile needs to check whether HDF5 is serial or parallel, if we want to maintain a functional MPI-free build path.

@reguly
Copy link
Collaborator

reguly commented Nov 12, 2021

@bozbez this should be useful for the new build system too

@aowenson
Copy link
Collaborator Author

Shall I close this and delete branch? Seems like Joe is handling this.

@bozbez
Copy link
Collaborator

bozbez commented Nov 22, 2021

I think we were discussing moving out the current state of the master branch into a release branch for the current Hydra iteration - in that case then this patch may still be useful for that branch, so perhaps leave it open for now and we can point it at release/OP2-Hydra-v1.0 or similar when it materialises?

@gihanmudalige
Copy link
Collaborator

Yes, leave this for now. Will be useful for the current OP2-Hydra.

@bozbez bozbez changed the base branch from master to release/OP2-Hydra-v1.0 December 1, 2021 12:09
@bozbez
Copy link
Collaborator

bozbez commented Dec 1, 2021

I think this is fine as a fix but as a note the HDF5 support for the MPI variants gets compiled into libop2_mpi.a, with libop2_hdf5.a only being used for the non-MPI app variants. This means we should probably just always compile with CXX and enable/disable the rule based on the presence of the sequential HDF5 library. If we compile libop2_hdf5.a with MPICXX then we also have to compile the sequential apps with MPICXX or manually pass the MPI libraries (as is currently done).

In the feature/unified-make support the libop2_hdf5.a and sequential HDF5 app variants are only built if a sequential HDF5 installation is available, and the same with the presence of a parallel HDF5.

@bozbez bozbez changed the base branch from release/OP2-Hydra-v1.0 to release/2020 December 1, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants