Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAS-1011 Replace unmaintained actions/create-release and update google-github-actions/setup-gcloud #75

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

arroyoAle
Copy link
Contributor

@arroyoAle arroyoAle commented Apr 3, 2024

What and why?

Replacing the unmaintained create release action with a github command that does the same and updating the setup-gcloud

How to test?

Check the build

Jira

https://jira.ons.gov.uk/browse/RAS-1011

@arroyoAle arroyoAle marked this pull request as ready for review April 3, 2024 10:44
Copy link
Contributor

@matthew-robinson-ons matthew-robinson-ons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good

Copy link
Contributor

@SteveScorfield SteveScorfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct. Approved

@arroyoAle arroyoAle merged commit e8f989b into main Apr 12, 2024
1 check passed
@arroyoAle arroyoAle deleted the replace-create-release branch April 12, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants