Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAS-837 Rops Security Alerts #875

Merged
merged 5 commits into from
Aug 2, 2023
Merged

Conversation

LJBabbage
Copy link
Contributor

@LJBabbage LJBabbage commented Jul 28, 2023

What and why?

Address dependabot issues

How to test?

Make sure the app works as before

Trello

@@ -46,7 +46,7 @@ email_validator = "*"
[dev-packages]
black = "*"
flake8 = "*"
djlint = "*"
djlint = "==1.25.0"
Copy link
Contributor Author

@LJBabbage LJBabbage Aug 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

djlint is causing issues when the lock file is regenerated, it concerns html linting. It's not related to this story and isn't one of the dependabot PRs, and should be fixed properly, so I will raise another card and pin it for the moment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@SteveScorfield
Copy link
Contributor

/deploy scorfs

@ras-rm-pr-bot
Copy link
Collaborator

Deploying to dev cluster with following parameters:

  • namespace: scorfs

  • tag: pr-875

  • configBranch: main

  • paramKey: ``

  • paramValue: ``

Copy link
Contributor

@SteveScorfield SteveScorfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@@ -46,7 +46,7 @@ email_validator = "*"
[dev-packages]
black = "*"
flake8 = "*"
djlint = "*"
djlint = "==1.25.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@LJBabbage LJBabbage merged commit 35994ca into main Aug 2, 2023
1 check passed
@LJBabbage LJBabbage deleted the update-packages-to-fix-dependabot-prs branch August 2, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants