Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added write_csv to save a Pandas df to s3 bucket using boto3 client.
Added a function write_csv to rdsa_utils\cdp\helpers\s3_utils.py. This function utilises Pandas to_csv method and can potentially take any keyword arguments of it. The content of the dataframe is initially serialised into a StringIO buffer. Then, we use the boto3 client's method put_object. Unit-testing is done using the mocking, via moto library. Three unit tests are added: that True is returned if successful, that the written CSV can be read back and gives the same dataframe, and a negative test, such as if it fails, False is returned. The failure is realised by trying to apply to_csv to a dictionary, which does not have this method.This pr introduces....
Type of change
You can delete options that are not relevant.
Checklist:
Peer review
Any new code includes all the following:
Review comments
Suggestions should be tailored to the code that you are reviewing. Provide context.
Be critical and clear, but not mean. Ask questions and set actions.
These might include:
that it is likely to interact with?)
works correctly? Are there additional edge cases/ negative tests to be considered?
Further reading: code review best practices