RAS-1228: Bug: Party service workers getting 139 SIGSEGV errors and restarting #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/deploy scorfs |
|
Deploying to dev cluster with following parameters:
|
|
/deploy scorfs |
|
Deploying to dev cluster with following parameters:
|
SteveScorfield
commented
Sep 10, 2024
There was a problem hiding this comment.
Not sure I like the naming of this. But I couldn't think what would be a good name for this.
SteveScorfield
commented
Sep 10, 2024
There was a problem hiding this comment.
Due to the retrieval of the enrolment DTO, I had to extract these functions out of the unified_business_party_functions.py
SteveScorfield
commented
Sep 10, 2024
| @@ -79,6 +79,13 @@ def get_business_by_ref(ref): | |||
| return jsonify(business) | |||
|
|
|||
|
|
|||
| @business_view.route("/businesses/ref/reporting-unit-only/<ref>", methods=["GET"]) | |||
There was a problem hiding this comment.
Not keen on the naming of this endpoint. Any ideas?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
There have been a lot of 139 SIGSEGV errors and restarting by the service. The main culprit appears to be the way the calls are being handled and data retrieval of the associations. Due to the complexity of the interconnections between the services, it wasn't possible to separate the calls to associations. There needs to be further investigation into what services are calling the endpoints and whether they actually need the associations.
This code change extracts out the various data dictionaries used by the business and party into one unified dictionary.
A new endpoint has been added that when called will only not bring back associations. I think this is the way to goto to help minimise the amount of calls being made.
How to test?
Jira
https://jira.ons.gov.uk/browse/RAS-1228