-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to database exception handling #410
Conversation
/deploy scorfs |
Deploying to dev cluster with following parameters:
|
/deploy scorfs |
Deploying to dev cluster with following parameters:
|
/deploy scorfs |
Deploying to dev cluster with following parameters:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and tested. Works as expected. PR Approved.
/deploy robinm3 |
Deploying to dev cluster with following parameters:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good and was able to recreate the exception. Might need to resolve the jinja2 vulnerability before merge as it failed the build in other repos.
What and why?
DB exception handling was a little bit of a scattershot approach when implemented because SQLAlchemy's exceptions aren't that good. This is a best attempt at refining it a bit for alerting purposes
How to test?
Jira
RAS-901