Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to database exception handling #410

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Conversation

mfcrocker
Copy link
Contributor

What and why?

DB exception handling was a little bit of a scattershot approach when implemented because SQLAlchemy's exceptions aren't that good. This is a best attempt at refining it a bit for alerting purposes

How to test?

  • Spin up an environment
  • Kill postgres
  • Do anything that would call Party
  • Check Party logs for the exception

Jira

RAS-901

@SteveScorfield
Copy link
Contributor

/deploy scorfs

@ras-rm-pr-bot
Copy link
Collaborator

Deploying to dev cluster with following parameters:

  • namespace: scorfs

  • tag: pr-410

  • configBranch: main

  • paramKey: ``

  • paramValue: ``

@SteveScorfield
Copy link
Contributor

/deploy scorfs

@ras-rm-pr-bot
Copy link
Collaborator

Deploying to dev cluster with following parameters:

  • namespace: scorfs

  • tag: pr-410

  • configBranch: main

  • paramKey: ``

  • paramValue: ``

@SteveScorfield
Copy link
Contributor

/deploy scorfs

@ras-rm-pr-bot
Copy link
Collaborator

Deploying to dev cluster with following parameters:

  • namespace: scorfs

  • tag: pr-410

  • configBranch: main

  • paramKey: ``

  • paramValue: ``

Copy link
Contributor

@SteveScorfield SteveScorfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested. Works as expected. PR Approved.

@matthew-robinson-ons
Copy link
Contributor

/deploy robinm3

@ras-rm-pr-bot
Copy link
Collaborator

Deploying to dev cluster with following parameters:

  • namespace: robinm3

  • tag: pr-410

  • configBranch: main

  • paramKey: ``

  • paramValue: ``

Copy link
Contributor

@matthew-robinson-ons matthew-robinson-ons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and was able to recreate the exception. Might need to resolve the jinja2 vulnerability before merge as it failed the build in other repos.

@mfcrocker mfcrocker merged commit 43e7e5a into main Feb 28, 2024
1 check passed
@mfcrocker mfcrocker deleted the refine-database-exceptions branch February 28, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants