Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update set-output to environment variables #408

Merged
merged 4 commits into from
Dec 11, 2023

Conversation

matthew-robinson-ons
Copy link
Contributor

What and why?

This PR replaces set-output within the .github workflow file with environment variables to fix a deprecation with set-output. It also updates actions/auth to v2.

How to test?

Check the github builds for any deprecation warnings and ensure the workflow functions after the changes.

Jira

https://jira.ons.gov.uk/secure/RapidBoard.jspa?rapidView=1493&projectKey=RAS&view=detail&selectedIssue=RAS-915

Copy link
Contributor

@anwilkie anwilkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github build looks fine, although there is an ignored warning in the tests.

@arroyoAle
Copy link
Contributor

/deploy arroya

@ras-rm-pr-bot
Copy link
Collaborator

Deploying to dev cluster with following parameters:

  • namespace: arroya

  • tag: pr-408

  • configBranch: main

  • paramKey: ``

  • paramValue: ``

Copy link
Contributor

@arroyoAle arroyoAle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build looks good and image runs fine

@matthew-robinson-ons matthew-robinson-ons merged commit ed28e3a into main Dec 11, 2023
1 check passed
@matthew-robinson-ons matthew-robinson-ons deleted the fix-deprecated-set-outputs branch December 11, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants