Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RAS-843 Fix breaking changes for DS 63.0.0 #914

Merged
merged 2 commits into from
Jul 28, 2023
Merged

RAS-843 Fix breaking changes for DS 63.0.0 #914

merged 2 commits into from
Jul 28, 2023

Conversation

LJBabbage
Copy link
Contributor

@LJBabbage LJBabbage commented Jul 26, 2023 •
edited
Loading

What and why?

This PR updates the design system to 63.0.0 which has breaking changes.

  1. onsPagination component - N/A, frontstage doesn't use pagination
  2. onsMessage component Invalid name attribute on dl and div elements onsMessage components name and messageName removed
  3. onsImage components rename N/A, frontstage doesn't use image tags
  4. onsTable component name removed for tr td only used in cookies.html and no change needed
  5. onsIcon and list components rename N/A, frontstage doesn't use icon, but does list (updated)

How to test?

Check frontstage and that everything looks fine, then check I haven't missed any components. Nothing in these changes needs a screen reader or acceptance tests updated (Although rops does, so load both into GCP and then run the new acceptance tests then)

@LJBabbage LJBabbage mentioned this pull request Jul 27, 2023
Merged
SteveScorfield
SteveScorfield approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@SteveScorfield SteveScorfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@LJBabbage LJBabbage merged commit 9bdc1fa into main Jul 28, 2023
3 checks passed
@LJBabbage LJBabbage deleted the update-ds-to-63-0-0 branch July 28, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveScorfield SteveScorfield SteveScorfield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LJBabbage @SteveScorfield