Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

479 o weight constraints #70

Merged
merged 13 commits into from
Aug 9, 2024
Merged

479 o weight constraints #70

merged 13 commits into from
Aug 9, 2024

Conversation

Jday7879
Copy link
Collaborator

@Jday7879 Jday7879 commented Aug 9, 2024

Summary

Functionality to implement outlier weight constraints.
This calculates the derived question values post winsorisation and will update outlier weight for derived questions, adding flag column to denote which values have been updated.

Checklists

This pull request meets the following requirements:

  • installable with all dependencies recorded
  • runs without error
  • follows PEP8 and project specific conventions
  • appropriate use of comments, for example no descriptive comments
  • functions documented using Numpy style docstings
  • assumptions and decisions log considered and updated if appropriate
  • unit tests have been updated to cover essential functionality for a reasonable range of inputs and conditions
  • other forms of testing such as end-to-end and user-interface testing have been considered and updated as required
  • tests suite passes (locally as a minimum)
  • peer reviewed with review recorded

If you feel some of these conditions do not apply for this pull request, please
add a comment to explain why.

@Jday7879 Jday7879 requested a review from giuliag92 August 9, 2024 11:24
@Jday7879 Jday7879 marked this pull request as ready for review August 9, 2024 11:24
Copy link
Collaborator

@giuliag92 giuliag92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Jordan, this is great! I just made a minor comment on one of the docs. Great job!!

mbs_results/constrains.py Outdated Show resolved Hide resolved
@Jday7879
Copy link
Collaborator Author

Jday7879 commented Aug 9, 2024

@giuliag92 Changes have been made and ready for re review / approval :)

@Jday7879 Jday7879 requested a review from giuliag92 August 9, 2024 12:24
Copy link
Collaborator

@giuliag92 giuliag92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Great job, Jordan :)

@Jday7879 Jday7879 merged commit 36b8fd4 into main Aug 9, 2024
3 checks passed
@Jday7879 Jday7879 deleted the 479-o-weight-constraints branch August 9, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants