465 imputation links #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonZogk
reviewed
Aug 8, 2024
AntonZogk
reviewed
Aug 8, 2024
| df = df.query("{} in {}".format(date, selected_periods)) | ||
|
|
||
| links_df = df.melt( | ||
| id_vars=[date, sic, cell, question, imputed_value], |
There was a problem hiding this comment.
why imputed_value needs to be in index ?
There was a problem hiding this comment.
Am I right in thinking we are going to keep this in (following discussion on Teams)?
AntonZogk
reviewed
Aug 8, 2024
AntonZogk
reviewed
Aug 8, 2024
|
|
||
| """ | ||
| if selected_periods is not None: | ||
| df = df.query("{} in {}".format(date, selected_periods)) |
There was a problem hiding this comment.
Loved line 110 beautiful approach !
There was a problem hiding this comment.
Luke's work 🙂
AntonZogk
reviewed
Aug 9, 2024
AntonZogk
reviewed
Aug 9, 2024
AntonZogk
reviewed
Aug 9, 2024
AntonZogk
requested changes
Aug 9, 2024
AntonZogk
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Merging counts onto main data and pivoting by link_type.
Summing imputation_value by period, cell and question.
Add your summary here - keep it brief, to the point, and in plain English.
Checklists
This pull request meets the following requirements:
If you feel some of these conditions do not apply for this pull request, please
add a comment to explain why.