Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

409 imputation validation #49

Merged
merged 3 commits into from
Jul 11, 2024
Merged

409 imputation validation #49

merged 3 commits into from
Jul 11, 2024

Conversation

rowanhemsi
Copy link
Collaborator

@rowanhemsi rowanhemsi commented Jul 11, 2024 •
edited by AntonZogk
Loading

Summary

Validation for missing values post imputation

Checklists

This pull request meets the following requirements:

  • installable with all dependencies recorded
  • runs without error
  • follows PEP8 and project specific conventions
  • appropriate use of comments, for example no descriptive comments
  • functions documented using Numpy style docstings
  • assumptions and decisions log considered and updated if appropriate
  • unit tests have been updated to cover essential functionality for a reasonable range of inputs and conditions
  • other forms of testing such as end-to-end and user-interface testing have been considered and updated as required
  • tests suite passes (locally as a minimum)
  • peer reviewed with review recorded

If you feel some of these conditions do not apply for this pull request, please
add a comment to explain why.

AntonZogk
AntonZogk requested changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@AntonZogk AntonZogk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looking good, just needs some minor changes in the dosctrings

@rowanhemsi rowanhemsi requested review from AntonZogk and removed request for AntonZogk July 11, 2024 14:53
AntonZogk
AntonZogk approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@AntonZogk AntonZogk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merged :)

@rowanhemsi rowanhemsi merged commit 4e9fb07 into main Jul 11, 2024
3 checks passed
@rowanhemsi rowanhemsi deleted the 409-imputation-validation branch July 11, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntonZogk AntonZogk AntonZogk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rowanhemsi @AntonZogk