Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

432 further config validation #40

Merged
merged 6 commits into from
Jul 2, 2024
Merged

432 further config validation #40

merged 6 commits into from
Jul 2, 2024

Conversation

Jday7879
Copy link
Collaborator

@Jday7879 Jday7879 commented Jul 1, 2024 •
edited by AntonZogk
Loading

Summary

Updated docstrings for functions, created unit tests and new validation function for input cofig file validation.

Checklists

This pull request meets the following requirements:

  • installable with all dependencies recorded
  • runs without error
  • follows PEP8 and project specific conventions
  • appropriate use of comments, for example no descriptive comments
  • functions documented using Numpy style docstings
  • assumptions and decisions log considered and updated if appropriate
  • unit tests have been updated to cover essential functionality for a reasonable range of inputs and conditions
  • other forms of testing such as end-to-end and user-interface testing have been considered and updated as required
  • tests suite passes (locally as a minimum)
  • peer reviewed with review recorded

If you feel some of these conditions do not apply for this pull request, please
add a comment to explain why.

@Jday7879 Jday7879 requested a review from AntonZogk July 1, 2024 14:27
@Jday7879 Jday7879 marked this pull request as ready for review July 1, 2024 14:27
AntonZogk
AntonZogk approved these changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@AntonZogk AntonZogk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looking good. Happy to be merged once a summary is added to period_and_reference_not_given also left a minor optional comment about a variable name

@Jday7879
Copy link
Collaborator Author

Jday7879 commented Jul 2, 2024

@AntonZogk, made the suggested changes and will merge into main, thanks for the review :)

@Jday7879 Jday7879 merged commit 9984b43 into main Jul 2, 2024
3 checks passed
@Jday7879 Jday7879 deleted the 432-further-config-validation branch July 2, 2024 14:20
lhubbardONS pushed a commit that referenced this pull request Jul 4, 2024
@Jday7879 @lhubbardONS
432 further config validation (#40)
42dd43f 
* Added validation function to check period and response given

* Added tests for clean_and_merge function

* Remove code which is not needed

* Created unit tests for validation cases

* Added summary and updated names for loop elements

* Pre-commit hook changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntonZogk AntonZogk AntonZogk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jday7879 @AntonZogk