377 main script #34
Merged
377 main script #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jday7879
requested changes
Jun 19, 2024
| import json | ||
|
|
||
|
|
||
| def load_config(path="config.json"): |
There was a problem hiding this comment.
Function is missing doc strings. Seems a pretty self explanatory function based on its name but might be worth adding quickly
| # basic logging | ||
| # kwargs in config | ||
|
|
||
| config = load_config() |
There was a problem hiding this comment.
Had to install research_and_development==1.0.0 to get main script to run. Getting error relating to json loading on L19.
|
Branch has been reviewed and passes all tests and could be merged. Not merging into main until 374 and 376 branches are merged to check for conflicts |
* Create function to change datatypes * Update config to use nested dictionary for column and data type * Added test to verify functionality * Added functionality to drop cols without deleting type * Corrected function inputs * Adding docstrings * Corrected differences in types for reference * Adding comments * Modified main to test implementation * Update to raise ValueError when datatypes are different * Refactored to add functions to validate datatype inputs and if repeated cols have conflicting types * Adding docstrings to validation functions * Updated function to work with reference and period as index. Currently resets index but looking into avoiding this * Cleaned up function and documentation * Remove print statement * Update module path to pass unit tests
merging main to fix conflicts
Jday7879
approved these changes
Jun 28, 2024
lhubbardONS
pushed a commit
that referenced
this pull request
Jul 4, 2024
* add config and change src name * begin to filter input data * basic date preparation * Corrected module path so unit tests run correctly * Update Requirements * Commenting out packages not on PyPI * Validate input datasets (#39) * 374 convert types (#37) * Create function to change datatypes * Update config to use nested dictionary for column and data type * Added test to verify functionality * Added functionality to drop cols without deleting type * Corrected function inputs * Adding docstrings * Corrected differences in types for reference * Adding comments * Modified main to test implementation * Update to raise ValueError when datatypes are different * Refactored to add functions to validate datatype inputs and if repeated cols have conflicting types * Adding docstrings to validation functions * Updated function to work with reference and period as index. Currently resets index but looking into avoiding this * Cleaned up function and documentation * Remove print statement * Update module path to pass unit tests * Moving validation checks into validation_checks.py from data_cleaning * Updated module path * Update docstrings --------- Co-authored-by: roberw <[email protected]> Co-authored-by: dayj1 <[email protected]> Co-authored-by: Jordan-Day-ONS <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add your summary here - keep it brief, to the point, and in plain English.
Checklists
This pull request meets the following requirements:
If you feel some of these conditions do not apply for this pull request, please
add a comment to explain why.