Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

628 csw to spp converter #120

Merged
merged 6 commits into from
Nov 4, 2024
Merged

628 csw to spp converter #120

merged 6 commits into from
Nov 4, 2024

Conversation

ldavies99
Copy link
Collaborator

Summary

Add your summary here - keep it brief, to the point, and in plain English.

Checklists

This pull request meets the following requirements:

  • installable with all dependencies recorded
  • runs without error
  • follows PEP8 and project specific conventions
  • appropriate use of comments, for example no descriptive comments
  • functions documented using Numpy style docstings
  • assumptions and decisions log considered and updated if appropriate
  • unit tests have been updated to cover essential functionality for a reasonable range of inputs and conditions
  • other forms of testing such as end-to-end and user-interface testing have been considered and updated as required
  • tests suite passes (locally as a minimum)
  • peer reviewed with review recorded

If you feel some of these conditions do not apply for this pull request, please
add a comment to explain why.

@ldavies99 ldavies99 requested a review from BixLaw October 31, 2024 14:31
@ldavies99 ldavies99 self-assigned this Oct 31, 2024
Copy link
Collaborator

@BixLaw BixLaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think theres an issue with line 112 on csw_to_spp_converter. Your using your personal file location, i believe this needs to be made generic.

Also out of curiosity the first two listed items in the mapper seem identical, what are they changing?

Otherwise looks good, nice and simple to understand. Well done

@ldavies99 ldavies99 requested a review from BixLaw November 4, 2024 10:23
@ldavies99 ldavies99 merged commit 820eb42 into main Nov 4, 2024
5 checks passed
@ldavies99 ldavies99 deleted the 628-csw-to-spp-converter branch November 4, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants