Merge pull request #3088 from ONSdigital/fix-for-destination-picker

fix for destination picker with LC
ONSdigital · Jan 5, 2024 · 8176a2c · 8176a2c
2 parents 5e08c9b + 9212544
commit 8176a2c
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/eq-author/README.md b/eq-author/README.md
@@ -112,3 +112,4 @@ theme colours and action names.
 `yarn storybook` Start the local server.
 
 `yarn build-storybook -o ../docs` deploy updates to static site (run from eq-author folder).
+
diff --git a/eq-author/src/App/page/Logic/Routing/DestinationSelector/RoutingDestinationContentPicker.js b/eq-author/src/App/page/Logic/Routing/DestinationSelector/RoutingDestinationContentPicker.js
@@ -1,6 +1,6 @@
 import React, { useState, useMemo } from "react";
 import PropTypes from "prop-types";
-import { takeRightWhile } from "lodash";
+import { takeRightWhile, reject } from "lodash";
 
 import {
   ContentSelectButton,
@@ -42,12 +42,19 @@ export const generateAvailableRoutingDestinations = (
   const currentSectionPages = currentSection.folders.flatMap(
     ({ pages }) => pages
   );
-  const routablePages = takeRightWhile(
+  let routablePages = takeRightWhile(
     currentSectionPages,
     ({ id }) => id !== pageId
   );
   routablePages.forEach((page) => (page.section = currentSection));
 
+  routablePages = reject(routablePages, {
+    pageType: "ListCollectorAddItemPage",
+  });
+  routablePages = reject(routablePages, {
+    pageType: "ListCollectorConfirmationPage",
+  });
+
   return {
     pages: routablePages || [],
   };

diff --git a/eq-author/src/App/page/Logic/Routing/DestinationSelector/index.js b/eq-author/src/App/page/Logic/Routing/DestinationSelector/index.js
@@ -16,7 +16,7 @@ const DESTINATION_TYPE = {
   Section: "Section",
   QuestionPage: "QuestionPage",
   CalculatedSummaryPage: "CalculatedSummaryPage",
-  ListCollectorPage: "ListCollectorPage",
+  ListCollectorPage: "ListCollectorQualifierPage",
 };
 
 const RoutingRuleResult = styled.div`