Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Information Page #21

Open
wants to merge 42 commits into
base: main
Choose a base branch
from
Open

Add Information Page #21

wants to merge 42 commits into from
+158 −0

Conversation

sanjeevz3009
Copy link

@sanjeevz3009 sanjeevz3009 commented Nov 7, 2024 •
edited
Loading

What is the context of this PR?

JIRA Ticket: https://jira.ons.gov.uk/browse/CMS-179

Create an Information Page model in Wagtail CMS to allow content editors to manage structured information pages.

Changes and Additions

  • HTML template created for the information page.
  • Django Model created for Information Page

How to review

  • Spin up the project in your local machine
  • Run the linters, code formatters and run the tests locally to make sure it's passing

Create an information page

  • Go to localhost:8000
  • Navigate to the Wagtail admin site localhost:8000/admin
  • Within Wagtail Admin -> Pages -> Home -> Add Child Page
  • Then you should be able to fill in the content of the information page and publish.

Untitled design

Screenshot 2024-11-07 at 17 30 10 Screenshot 2024-11-07 at 17 30 20

Information Page Example

Screenshot 2024-11-07 at 18 31 48

Follow-up Actions

List any follow-up actions (if applicable), like needed documentation updates or additional testing.

nehakerung and others added 19 commits November 1, 2024 11:33
@nehakerung
Standard_pages app creation
2dfa81d
@nehakerung
Addition of InformationPage class in models
7c35050
@nehakerung
Changes to InformationPage class models
93bb753
@nehakerung
Front end creation
5d4ec7d
@nehakerung
Addition of template location and minor changes on information_page t…
ddcaee6 
…emplate for testing
@nehakerung
Added cms.standard_pages to installed_apps
72d7fda
@nehakerung
Updated apps.py for standard_pages to be similar to pre-existing apps
4e6cb4f
@nehakerung
Modified InformationPage in models
0ba0955
@nehakerung
Updated template for informationPage
afc6363
@nehakerung
Modified models for standard_pages
de7c9bb
@nehakerung
Modified front end
4a0a36b
@nehakerung
working branch
b1f8eda
@sanjeevz3009
Django models for information page updated and the template for the i…
41d8bd2 
…nformation page tweaked
@sanjeevz3009
Zombie code removed
29af196
@sanjeevz3009
Unnused files deleted
ea31520
@sanjeevz3009
Mirgation file formatted
93e22b8
@sanjeevz3009
django-manager-missing ignore added
524836e
@sanjeevz3009
TODO comment removed and docstrings added
47316d4
@sanjeevz3009
Merge branch 'main' into feature/information-page-CMS-179
7f0ae06
zerolab
zerolab requested changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start!

Added a few notes and suggestions as a first pass.

cms/jinja2/templates/pages/information_page.html Outdated Show resolved Hide resolved
cms/standard_pages/models.py Outdated Show resolved Hide resolved
cms/standard_pages/models.py Show resolved Hide resolved
cms/standard_pages/models.py Outdated Show resolved Hide resolved
cms/standard_pages/models.py Outdated Show resolved Hide resolved
cms/jinja2/templates/pages/information_page.html Outdated Show resolved Hide resolved
cms/jinja2/templates/pages/information_page.html Outdated Show resolved Hide resolved
@sanjeevz3009 sanjeevz3009 marked this pull request as ready for review November 7, 2024 17:38
@sanjeevz3009 sanjeevz3009 requested a review from a team as a code owner November 7, 2024 17:38
zerolab
zerolab approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

MebinAbraham
MebinAbraham approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@MebinAbraham MebinAbraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work both 👍

cms/static_src/sass/main.scss Outdated Show resolved Hide resolved
cms/release_calendar/models.py Outdated Show resolved Hide resolved
zerolab
zerolab requested changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@zerolab zerolab left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small changes needed (but lovely first feature 💪🏼 )

cms/jinja2/templates/pages/information_page.html Outdated Show resolved Hide resolved
media/documents/file.txt Outdated Show resolved Hide resolved
MebinAbraham
MebinAbraham approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@MebinAbraham MebinAbraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing else that's not already been raised.

👍

sanjeevz3009
sanjeevz3009 commented Nov 14, 2024
View reviewed changes
media/documents/file.txt Outdated Show resolved Hide resolved
cms/jinja2/templates/pages/information_page.html Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nehakerung nehakerung nehakerung left review comments

@zerolab zerolab zerolab approved these changes

@MebinAbraham MebinAbraham MebinAbraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sanjeevz3009 @zerolab @MebinAbraham @nehakerung