Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add profile labels to collection point profile type #3938

Merged

Conversation

benfurber
Copy link
Member

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Feature (adds functionality)

What is the current behavior?

Collection points use two custom fields for setting and displaying data.

What is the new behavior?

Uses only the new generic profile tags field.

Screenshot 2024-10-23 at 14 21 02

Does this PR introduce a breaking change?

  • Yes
  • No

Git Issues

Part of #3908

@benfurber benfurber requested a review from a team as a code owner October 23, 2024 13:30
@benfurber
Copy link
Member Author

@davehakkens Thinking about the screen shot. There's seven plastic types but we're asking users to select a max of five tags. Not a big deal just thought I'd note it.

@benfurber
Copy link
Member Author

Will start on the data update now.

As there's two fields to change the plan is to set the plastic types as tags and add the open times to user's about field. There's a risk the open times are already on the about not from a random sample of live profiles, they weren't mentioned.

@benfurber benfurber changed the title Feat/profile labels/collection point Feat: add profile labels to collection point profile type Oct 23, 2024
@benfurber benfurber force-pushed the feat/profile-labels/collection-point branch from 3d0a92c to 54caeb2 Compare October 23, 2024 13:37
Copy link

cypress bot commented Oct 23, 2024

onearmy-community-platform    Run #6456

Run Properties:  status check passed Passed #6456  •  git commit 8d5d9781d0: feat: change collection profile to use tags
Project onearmy-community-platform
Branch Review pull/3938
Run status status check passed Passed #6456
Run duration 05m 50s
Commit git commit 8d5d9781d0: feat: change collection profile to use tags
Committer Ben Furber
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 73
View all changes introduced in this branch ↗︎

@davehakkens
Copy link
Contributor

As there's two fields to change the plan is to set the plastic types as tags and add the open times to user's about field. There's a risk the open times are already on the about not from a random sample of live profiles, they weren't mentioned.

Potentially opening times could be coupled with the "open for visits feature" making it available for all profiles which could be quite useful

Feature:
Are you open for visitors

  • No
  • yes on appointment
  • yes (select opening times)

@iSCJT iSCJT added the Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview label Oct 24, 2024
@benfurber benfurber force-pushed the feat/profile-labels/collection-point branch from 54caeb2 to d2bba74 Compare October 24, 2024 17:10
@iSCJT iSCJT added Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview and removed Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview labels Oct 24, 2024
@iSCJT iSCJT removed the Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview label Oct 24, 2024
@benfurber benfurber force-pushed the feat/profile-labels/collection-point branch from 617eeca to 8d5d978 Compare October 28, 2024 14:26
@benfurber benfurber merged commit 1132134 into ONEARMY:master Oct 28, 2024
18 of 19 checks passed
@benfurber benfurber deleted the feat/profile-labels/collection-point branch October 28, 2024 14:48
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 2.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants