-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add profile labels to collection point profile type #3938
Feat: add profile labels to collection point profile type #3938
Conversation
@davehakkens Thinking about the screen shot. There's seven plastic types but we're asking users to select a max of five tags. Not a big deal just thought I'd note it. |
Will start on the data update now. As there's two fields to change the plan is to set the plastic types as tags and add the open times to user's about field. There's a risk the open times are already on the about not from a random sample of live profiles, they weren't mentioned. |
3d0a92c
to
54caeb2
Compare
onearmy-community-platform Run #6456
Run Properties:
|
Project |
onearmy-community-platform
|
Branch Review |
pull/3938
|
Run status |
Passed #6456
|
Run duration | 05m 50s |
Commit |
8d5d9781d0: feat: change collection profile to use tags
|
Committer | Ben Furber |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
3
|
Pending |
0
|
Skipped |
0
|
Passing |
73
|
View all changes introduced in this branch ↗︎ |
Potentially opening times could be coupled with the "open for visits feature" making it available for all profiles which could be quite useful Feature:
|
54caeb2
to
d2bba74
Compare
617eeca
to
8d5d978
Compare
🎉 This PR is included in version 2.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Collection points use two custom fields for setting and displaying data.
What is the new behavior?
Uses only the new generic profile tags field.
Does this PR introduce a breaking change?
Git Issues
Part of #3908