-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add profile labels to machine profile type #3904
feat: add profile labels to machine profile type #3904
Conversation
@mariojsnunes I'm starting to work on this Ideally the labels are DB stored/content editable for mods. But I'd rather that done later down the line. Do you think this service pattern is appropriate for this usecase? These labels will end up being called at least on the map, profiles and settings. |
onearmy-community-platform Run #6392
Run Properties:
|
Project |
onearmy-community-platform
|
Branch Review |
pull/3904
|
Run status |
Passed #6392
|
Run duration | 17m 01s |
Commit |
2a2be7452d: feat: update architectural design
|
Committer | Ben Furber |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
5
|
Pending |
0
|
Skipped |
0
|
Passing |
78
|
View all changes introduced in this branch ↗︎ |
Are you making them profile-type specific @benfurber? -as they should work cross all profile-types |
@davehakkens Generic is the direction of travel. |
Looks good! It can easily evolve into calling an API |
538d7cf
to
f7b655d
Compare
c6186d7
to
70e8609
Compare
0e53d29
to
e798c84
Compare
What is the end state of the travel you have in mind @benfurber? -so I understand better how to 'review' this |
e798c84
to
2f92bf6
Compare
Nice thanks for the update. Sounds good to me |
116a9b3
to
3ba17a4
Compare
Update. Worked with Mario on this for a bit. We got caught on a build error. Going to change the tech approach on this. Will resume work on it Monday. |
(All the hard work is in this branch, most of the rest should be straightforward after this.) |
cf1eed6
to
2b8d163
Compare
c33f8e3
to
88309cb
Compare
88309cb
to
2a2be74
Compare
Right. I think is is finally ready now. So will work on the PP database change tomorrow. |
Data updated and looking good. Deploying this now. |
🎉 This PR is included in version 2.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently the profile type machine shop has a custom profile attribute.
What is the new behavior?
This removes that custom attribute and replaces it with a more generic field that all profile types will eventually use.
https://www.figma.com/design/x4DcaUjwiigjCySAt5omxB/CP-%2F-Signup%2C-Settings-and-Gatekeeping?node-id=1140-2633&node-type=frame&t=MryI3JVwVnwhTJMn-11
Part of #3908