Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add profile labels to machine profile type #3904

Merged
merged 7 commits into from
Oct 23, 2024

Conversation

benfurber
Copy link
Member

@benfurber benfurber commented Oct 11, 2024

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Feature (adds functionality)
  • Code style update
  • Refactoring (no functional changes)
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the current behavior?

Currently the profile type machine shop has a custom profile attribute.

What is the new behavior?

This removes that custom attribute and replaces it with a more generic field that all profile types will eventually use.

Screenshot 2024-10-16 at 14 17 12 Screenshot 2024-10-17 at 13 14 46 Screenshot 2024-10-17 at 13 36 18

https://www.figma.com/design/x4DcaUjwiigjCySAt5omxB/CP-%2F-Signup%2C-Settings-and-Gatekeeping?node-id=1140-2633&node-type=frame&t=MryI3JVwVnwhTJMn-11

Part of #3908

@benfurber
Copy link
Member Author

@mariojsnunes I'm starting to work on this

Ideally the labels are DB stored/content editable for mods. But I'd rather that done later down the line. Do you think this service pattern is appropriate for this usecase? These labels will end up being called at least on the map, profiles and settings.

Copy link

cypress bot commented Oct 11, 2024

onearmy-community-platform    Run #6392

Run Properties:  status check passed Passed #6392  •  git commit 2a2be7452d: feat: update architectural design
Project onearmy-community-platform
Branch Review pull/3904
Run status status check passed Passed #6392
Run duration 17m 01s
Commit git commit 2a2be7452d: feat: update architectural design
Committer Ben Furber
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 5
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 78
View all changes introduced in this branch ↗︎

@davehakkens
Copy link
Contributor

davehakkens commented Oct 11, 2024

Are you making them profile-type specific @benfurber? -as they should work cross all profile-types

@benfurber
Copy link
Member Author

Are you making them profile-type specific @benfurber? -as they should work cross all profile-types

@davehakkens Generic is the direction of travel.

@mariojsnunes
Copy link
Contributor

@mariojsnunes I'm starting to work on this

Ideally the labels are DB stored/content editable for mods. But I'd rather that done later down the line. Do you think this service pattern is appropriate for this usecase? These labels will end up being called at least on the map, profiles and settings.

Looks good! It can easily evolve into calling an API

@benfurber benfurber force-pushed the feat/profile-labels/machines branch 2 times, most recently from c6186d7 to 70e8609 Compare October 17, 2024 12:11
@benfurber benfurber marked this pull request as ready for review October 17, 2024 14:06
@benfurber benfurber requested a review from a team as a code owner October 17, 2024 14:06
@davehakkens
Copy link
Contributor

davehakkens commented Oct 17, 2024

What is the end state of the travel you have in mind @benfurber? -so I understand better how to 'review' this

@benfurber
Copy link
Member Author

@davehakkens
Copy link
Contributor

Nice thanks for the update. Sounds good to me

@benfurber
Copy link
Member Author

Update. Worked with Mario on this for a bit. We got caught on a build error. Going to change the tech approach on this. Will resume work on it Monday.

@benfurber
Copy link
Member Author

(All the hard work is in this branch, most of the rest should be straightforward after this.)

@benfurber benfurber force-pushed the feat/profile-labels/machines branch 3 times, most recently from cf1eed6 to 2b8d163 Compare October 22, 2024 12:40
@benfurber benfurber force-pushed the feat/profile-labels/machines branch 2 times, most recently from c33f8e3 to 88309cb Compare October 22, 2024 13:08
@benfurber
Copy link
Member Author

Right. I think is is finally ready now. So will work on the PP database change tomorrow.

@benfurber
Copy link
Member Author

Data updated and looking good. Deploying this now.

@benfurber benfurber merged commit 969ebbd into ONEARMY:master Oct 23, 2024
19 of 20 checks passed
@benfurber benfurber deleted the feat/profile-labels/machines branch October 23, 2024 10:33
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 2.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants