Applayer plugin 5053 v9 #12465
Closed
Applayer plugin 5053 v9 #12465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and use generic logger callback prototype with later cast and do some other small modifications so that the plugin has less diff
Just use a regular compile time rust export, instead of having a runtime definition through the SuricataContext structure
so that it can be used by plugins Avoid export by cbindgen as this constant is also defined in C
so that it can be used by plugins that want to call SCLogError and such
so that they can be used by rust plugins
Ticket: 7151 Ticket: 7152 Ticket: 7154
Ticket: 7149 Ticket: 7150 Ticket: 7153
catenacyber
requested review from
jasonish,
jufajardini,
victorjulien and
a team
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12465 +/- ##
==========================================
+ Coverage 80.63% 80.67% +0.03%
==========================================
Files 920 920
Lines 258739 259102 +363
==========================================
+ Hits 208643 209036 +393
+ Misses 50096 50066 -30
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 24341 |
|
Next in #12467 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/4102 with all 6 subtickets
Describe changes:
@jufajardini what do you think about the doc ?
#12455 rebased without restricting
JsonBuilderbeing pub, but warning in the doc about the non intuitive way that must be used in pluginsI think this is not a draft, but it can benefit from one part of #12461 with the
suricata-syscrateThere is also #12420 that can be merged first, which will require a rebase of this one
cc @jasonish
We can still do a cleanup of rust
pubpub(crate)andpub(super)but it is not the matter here...