detect/integers: add support for negated strings when enum is used - v1 #12444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
function detect_parse_uint_enum can parse strings like !bind_request Ticket: OISF#7513
catenacyber
reviewed
Jan 21, 2025
| pub fn detect_parse_uint_enum<T1: DetectIntType, T2: EnumString<T1>>( | ||
| s: &str, | ||
| ) -> Option<DetectUintData<T1>> { | ||
| let (s, neg) = opt::<&str, _, Error<_>, _>(char('!'))(s).ok()?; |
There was a problem hiding this comment.
@jasonish do you know simpler rust ?
|
And needs green CI for |
5 tasks
|
Replaced by: #12453 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #7513
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
(including schema descriptions)
https://redmine.openinfosecfoundation.org/projects/suricata/issues
Link to ticket: https://redmine.openinfosecfoundation.org/issues/7513
Describe changes: