Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns: improved handling of corrupt additionals #12349

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7228

Describe changes:

  • dns: improved handling of corrupt additionals

SV_BRANCH=OISF/suricata-verify#2032

#11794 rebased after latest DNS changes (like #11870 )

@jasonish what do you think about it ?

Ticket: 7228

That means log the rest of queries and answers, even if the
final field additionals is corrupt.
Set an event in this case.
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.23%. Comparing base (def22fa) to head (02145a3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12349   +/-   ##
=======================================
  Coverage   83.23%   83.23%           
=======================================
  Files         912      912           
  Lines      257647   257673   +26     
=======================================
+ Hits       214450   214475   +25     
- Misses      43197    43198    +1     
Flag Coverage Δ
fuzzcorpus 61.21% <100.00%> (-0.01%) ⬇️
livemode 19.39% <0.00%> (-0.01%) ⬇️
pcap 44.43% <86.20%> (+0.03%) ⬆️
suricata-verify 62.87% <86.20%> (+0.01%) ⬆️
unittests 59.19% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 24108

Copy link
Member

@jasonish jasonish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think this is OK!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants