Skip to content

Commit

Permalink
Fixing issues after merging
Browse files Browse the repository at this point in the history
  • Loading branch information
alex-odysseus committed Nov 21, 2024
1 parent 1637ad9 commit 20e240a
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

<commons-fileupload.version>1.5</commons-fileupload.version>

<circe.version>1.11.2</circe.version>
<circe.version>1.11.4-SNAPSHOT</circe.version>
<jersey.version>2.14</jersey.version>
<SqlRender.version>1.16.1</SqlRender.version>
<hive-jdbc.version>3.1.2</hive-jdbc.version>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ public CohortGenerationRequest buildWithRetainCohortCovariates() {

return new CohortGenerationRequest(expression, source, sessionId, targetId, targetSchema,
retainCohortCovariates, cohortId);
}

public boolean hasRetainCohortCovariates() {
return retainCohortCovariates != null ? retainCohortCovariates.booleanValue() : false;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
import org.springframework.jdbc.core.JdbcTemplate;
import org.springframework.util.ObjectUtils;


import java.util.Arrays;
import java.util.List;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public JobExecutionResource generateCohortViaJob(UserEntity userEntity, CohortDe
return runGenerateCohortJob(cohortDefinition, source, retainCohortCovariates);
}

private Job buildGenerateCohortJob(CohortDefinition cohortDefinition, Source source, JobParameters jobParameters, Boolean retainCohortCovariates) {
private Job buildGenerateCohortJob(CohortDefinition cohortDefinition, Source source, JobParameters jobParameters) {

log.info("Beginning generate cohort for cohort definition id: {}", cohortDefinition.getId());

Expand Down Expand Up @@ -124,7 +124,7 @@ private Job buildGenerateCohortJob(CohortDefinition cohortDefinition, Source sou

private JobExecutionResource runGenerateCohortJob(CohortDefinition cohortDefinition, Source source, Boolean retainCohortCovariates) {
final JobParametersBuilder jobParametersBuilder = getJobParametersBuilder(source, cohortDefinition, retainCohortCovariates);
Job job = buildGenerateCohortJob(cohortDefinition, source, jobParametersBuilder.toJobParameters(), retainCohortCovariates);
Job job = buildGenerateCohortJob(cohortDefinition, source, jobParametersBuilder.toJobParameters());
return jobService.runJob(job, jobParametersBuilder.toJobParameters());
}

Expand Down

0 comments on commit 20e240a

Please sign in to comment.