Add support for InterSystems IRIS as an additional database platform #377
Conversation
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 2 to 4.1.7. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v2...v4.1.7) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
…-github/workflows/actions/download-artifact-4.1.7 Bump actions/download-artifact from 2 to 4.1.7 in /.github/workflows
|
I think this post was pretty clear: we don't have the resources to support more database platforms. The HADES workgroup is working on a manifesto for defining the minimum requirements under which we'd consider adding a new platform. The current thinking is:
|
|
Hi @schuemie , thanks for your response. Indeed the post you referenced was clear, and as such we've invested in anticipating these totally reasonable requirements. This is our PR for SqlRender, as we agreed with @alex-odysseus it would be the logical one to submit first given project interdependencies. We can surely trigger the one from our DatabaseConnector fork right away as you prefer, but rather have this discussion in one place. With the Odysseus Data Services team, we validated the key HADES packages over the past few months and would be happy to share their report, and look into any remaining ones you consider essential. As for the test server, we've been working with an externally accessible test server we can keep up and maintain for a while to come. As an alternative, we'd like to discuss an approach using docker images of our free tier that can be spun up using GitHub Actions, which we've used for a few other open source / community ventures. Please let us know if you'd like to set up a conversation or if there's any additional information or PRs we can provide right away. Thanks, |
|
I've accepted the PR, so you can proceed with showing that everything works. If the other requirements aren't met (test server, showing all HADES packages run on IRIS) support will be removed. Your PR broke several unit tests that I had to fix. This is not OK. In the future, run and pass all unit tests before submitting a PR. Also, please target the develop branch. |
|
Yes, please e-mail them to me |
|
@bdeboe v1.19.0 has just been released, which includes this PR |
|
That is great news. Thanks @schuemie ! |
Hi,
this PR introduces support for the InterSystems IRIS Data Platform to SqlRender. It includes all the required replacement rules to make sure OHDSI tool-generated statements run fine on InterSystems IRIS. In addition, appropriate unit tests and changes to the ref/doc pages are included in this PR.
This PR for SqlRender is the first step of adding InterSystems IRIS support to a broader set of OHDSI tools, as the dialect needs to become part of a SqlRender release in order to be able to submit corresponding PRs for the DatabaseConnector, CommonDataModel, ArachneCommons, WebAPI and Atlas repositories that we have lined up and ready to submit. As such, it would be great if this could make it into the upcoming 1.18.1 release, and we are ready to make any further changes to the PR as required to facilitate approval.
Context: Dr. Qi Li has recently reached out to @schuemie to discuss our work at InterSystems and the OHDSI toolset support effort, which we've done with support of the Oddyseus Data Services team and @alex-odysseus in particular.