Fixed DuckDb translation of CAST(CONCATENATE(...) AS DATE). Fixes #369

DESCRIPTION

@@ -2,7 +2,7 @@ Package: SqlRender
 Type: Package
 Title: Rendering Parameterized SQL and Translation to Dialects
 Version: 1.18.1
-Date: 2024-06-04
+Date: 2024-07-16s
 Authors@R: c(
   person("Martijn", "Schuemie", , "[email protected]", role = c("aut", "cre")),
   person("Marc", "Suchard", role = c("aut"))

NEWS.md

@@ -5,6 +5,10 @@ Changes:
 
 1. Changing Spark translation of `DATEADD()` from `DATE_ADD()` to `DATEADD()` as required by some but not all Databricks instances. 
 
+Bugfixes:
+
+1. Fixed DuckDb translation of `CAST(CONCATENATE(...) AS DATE)`.
+
 
 SqlRender 1.18.0
 ================

inst/csv/replacementPatterns.csv

@@ -1218,6 +1218,9 @@ duckdb,"CONVERT(VARCHAR,@date,112)","STRFTIME(@date, '%Y%m%d')"
 duckdb,GETDATE(),CURRENT_DATE
 duckdb,"CONVERT(DATE, @a)","CAST(@a AS DATE)"
 duckdb,"CAST('@a' AS DATE)","CAST(strptime('@a', '%Y%m%d') AS DATE)"
+duckdb,"CAST('@a' + @b AS DATE)","CAST(strptime('@a' + @b, '%Y%m%d') AS DATE)"
+duckdb,"CAST(@a + '@b' AS DATE)","CAST(strptime(@a + '@b', '%Y%m%d') AS DATE)"
+duckdb,"CAST(CONCAT(@a) AS DATE)","CAST(strptime(CONCAT(@a), '%Y%m%d') AS DATE)"
 duckdb,+ '@a',|| '@a'
 duckdb,'@a' +,'@a' ||
 duckdb,CAST(@a AS varchar(@b)) +,CAST(@a AS varchar(@b)) ||

tests/testthat/test-translate-duckdb.R

@@ -239,3 +239,11 @@ test_that("translate sql server -> duckdb NEWID", {
   sql <- translate("SELECT NEWID()", targetDialect = "duckdb")
   expect_equal_ignore_spaces(sql, "SELECT uuid()")
 })
+
+test_that("translate sql server -> DuckDB CONVERT(AS DATE) with literal from CONCAT", {
+  sql <- translate("CAST(CONCAT('2000', '0101') AS DATE);", targetDialect = "duckdb")
+  expect_equal_ignore_spaces(
+    sql,
+    "CAST(strptime(CONCAT('2000', '0101'), '%Y%m%d') AS DATE);"
+  )
+})