Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sklearn deprecated value for adaboost #512

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Conversation

egillax
Copy link
Collaborator

@egillax egillax commented Dec 9, 2024

Fixes #511

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 98.58586% with 7 lines in your changes missing coverage. Please review.

Project coverage is 86.15%. Comparing base (0645a72) to head (849eeb0).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
R/ParamChecks.R 60.00% 2 Missing ⚠️
R/SklearnClassifier.R 97.89% 2 Missing ⚠️
R/SklearnToJson.R 98.43% 2 Missing ⚠️
R/SklearnClassifierSettings.R 99.62% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #512      +/-   ##
===========================================
+ Coverage    86.11%   86.15%   +0.03%     
===========================================
  Files           50       50              
  Lines        10342    10385      +43     
===========================================
+ Hits          8906     8947      +41     
- Misses        1436     1438       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@egillax egillax merged commit 8e45507 into develop Dec 9, 2024
10 checks passed
@egillax egillax deleted the 511-samme-adaboost branch December 9, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant