Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add existing split #504

Merged
merged 5 commits into from
Nov 21, 2024
Merged

Add existing split #504

merged 5 commits into from
Nov 21, 2024

Conversation

egillax
Copy link
Collaborator

@egillax egillax commented Nov 18, 2024

No description provided.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.10%. Comparing base (77cc0bf) to head (7bddc38).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
R/DataSplitting.R 93.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #504      +/-   ##
===========================================
+ Coverage    86.06%   86.10%   +0.03%     
===========================================
  Files           50       50              
  Lines        10315    10328      +13     
===========================================
+ Hits          8878     8893      +15     
+ Misses        1437     1435       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@egillax egillax requested a review from jreps November 19, 2024 08:03
@egillax
Copy link
Collaborator Author

egillax commented Nov 19, 2024

Hi @jreps ,

I've added a new split settings where we use an existing split (dataframe with rowId, index). I ended up making the API a bit simpler than you suggested in the issue. Does this work for your use case?

@egillax egillax mentioned this pull request Nov 19, 2024
@jreps
Copy link
Collaborator

jreps commented Nov 21, 2024

Yeah - this works and is nice and simple :). This would solve the issue if we want the same patient split within a plpData object.

@egillax egillax merged commit fb99638 into develop Nov 21, 2024
10 checks passed
@egillax egillax deleted the existing_split branch November 21, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants