Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating develop with changes in main #480

Merged
merged 9 commits into from
Oct 2, 2024
Merged

updating develop with changes in main #480

merged 9 commits into from
Oct 2, 2024

Conversation

jreps
Copy link
Collaborator

@jreps jreps commented Sep 10, 2024

No description provided.

egillax and others added 7 commits April 26, 2024 20:53
@egillax
Version 6.3.8 (#446)
c5176a2 
* new external validation function based on validationDesign

* fix imports of sklearn modules and classes (#442)

* remove version from is_installed (#444)

* fix NOTES about documentation

* preserve randomness in table generation in tests
@egillax
Update R_CMD_check_main_weekly.yaml
8efa4f0 
add conda setup step - macOS runners stopped supplying default conda
@egillax
Update R_CMD_check_main_weekly.yaml
9c3f271
@egillax
Update R_CMD_check_Hades.yaml
d402935
@egillax
disable BigKnn tests
3827075
@jreps
hot fix for result table creation
1dfc46b
@jreps
updating website docs
9d1fb8c 
updating website docs
@egillax
Copy link
Collaborator

egillax commented Oct 1, 2024 •
edited
Loading

@jreps can this be merged? The diff is very weird though.. like it's against an older version of develop...

@jreps
Copy link
Collaborator Author

jreps commented Oct 1, 2024

I had to fix some conflicts - I've done this in the merge_main branch and will pull in once tests pass

@jreps
validation code test fixes
b69c591 
updating validation code/test that broke when fixing conflicts
@codecov Codecov
Copy link

codecov bot commented Oct 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.99%. Comparing base (cc92009) to head (b69c591).
Report is 11 commits behind head on develop.

Files with missing lines Patch % Lines
R/ExternalValidatePlp.R 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #480   +/-   ##
========================================
  Coverage    85.98%   85.99%           
========================================
  Files           50       50           
  Lines        10219    10218    -1     
========================================
  Hits          8787     8787           
+ Misses        1432     1431    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jreps jreps merged commit 5b8260d into develop Oct 2, 2024
9 of 10 checks passed
@jreps jreps deleted the merged_main branch October 2, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jreps @egillax