only restict to first if many observations per subjectId #419
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jreps
When we create our
population
withfirstExposureOnly
set to `TRUE there is a very expensive group_by operation done:The amount of groups is equal to amount of subjects, so possibly millions.
When there is only one observation per
subjectId
this is a no-op and can be skipped.In this PR I've added a condition:
If rows in population are more than amount of subjects (aka more observations than subjects), then and only then we do this expensive operation.
This took the population generation time down from about 1.4 minutes to 0.8 seconds for a cohort of about 460k.