Skip to content

Commit

Permalink
fix modelPaths in plpModel
Browse files Browse the repository at this point in the history
  • Loading branch information
egillax committed Oct 17, 2024
1 parent 5e229c0 commit 3b540e5
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions R/ExternalValidatePlp.R
Original file line number Diff line number Diff line change
Expand Up @@ -788,11 +788,12 @@ createDownloadTasks <- function(validationDesignList) {
plpModelList <- design$plpModelList
for (model in plpModelList) {
if (is.character(model)) {
if (!is.null(modelCache[[model]])) {
model <- modelCache[[model]]
modelKey <- model
if (!is.null(modelCache[[modelKey]])) {
model <- modelCache[[modelKey]]

Check warning on line 793 in R/ExternalValidatePlp.R

View check run for this annotation

Codecov / codecov/patch

R/ExternalValidatePlp.R#L791-L793

Added lines #L791 - L793 were not covered by tests
} else {
model <- loadPlpModel(model)
modelCache[[model]] <- model
model <- loadPlpModel(modelKey)
modelCache[[modelKey]] <- model

Check warning on line 796 in R/ExternalValidatePlp.R

View check run for this annotation

Codecov / codecov/patch

R/ExternalValidatePlp.R#L795-L796

Added lines #L795 - L796 were not covered by tests
}
} else {
modelKey <- digest::digest(model)
Expand Down

0 comments on commit 3b540e5

Please sign in to comment.