fix test that failed only during codecov

OHDSI · Apr 26, 2024 · 28949ba · 28949ba
1 parent 2f3eb40
commit 28949ba
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/.github/workflows/R_CMD_check_Hades.yaml b/.github/workflows/R_CMD_check_Hades.yaml
@@ -87,13 +87,13 @@ jobs:
           path: check/*.tar.gz
 
       - name: Install covr
-        if: runner.os == 'macOS'
+        if: runner.os == 'Linux'
         run: |
           remotes::install_cran("covr")
         shell: Rscript {0}
 
       - name: Test coverage
-        if: runner.os == 'macOS'
+        if: runner.os == 'Linux'
         run: covr::codecov()
         shell: Rscript {0}
 

diff --git a/R/AdditionalCovariates.R b/R/AdditionalCovariates.R
@@ -46,7 +46,8 @@ getCohortCovariateData <- function(
   rowIdField = "row_id",
   aggregated,
   cohortIds,
-  covariateSettings
+  covariateSettings,
+  ...
   ){
 
   # Some SQL to construct the covariate:

diff --git a/tests/testthat/test-UploadToDatabase.R b/tests/testthat/test-UploadToDatabase.R
@@ -31,10 +31,8 @@ connectionRedshift <- DatabaseConnector::createConnectionDetails(
 conn <- DatabaseConnector::connect(connectionRedshift)
 targetDialect <- 'postgresql'
 
-withr::with_seed(NULL, {
-  randVar <- rawToChar(as.raw(sample(c(65:90,97:122), 5, replace=T)))
-  }
-)
+set.seed(NULL)
+randVar <- rawToChar(as.raw(sample(c(65:90,97:122), 5, replace=T)))
 
 appendRandom <- function(x, rand = randVar){
   return(paste("plp", rand, x, sep=''))