Adding workaround for PLP vignette issue

OHDSI · Mar 28, 2024 · d8ede45 · d8ede45
1 parent 3192db2
commit d8ede45
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/extras/Releasing/PackageCheckFunctions.R b/extras/Releasing/PackageCheckFunctions.R
@@ -32,7 +32,7 @@ prepareForPackageCheck <- function() {
 #   }
 # }
 
-checkPackage <- function(package, inCran) {
+checkPackage <- function(package, inCran, additionalCheckArgs = c()) {
   writeLines(sprintf("*** Checking package '%s' ***", package))
   gitHubOrganization <- "ohdsi"
   if (inCran) {
@@ -53,7 +53,10 @@ checkPackage <- function(package, inCran) {
     unlink(docDir, recursive = TRUE)
   }
   # devtools::check_built(path = sourcePath)
-  rcmdcheck::rcmdcheck(path = sourcePath, args = c("--no-manual", "--no-multiarch", "--as-cran"), error_on = "warning")
+  rcmdcheck::rcmdcheck(path = sourcePath, 
+                       args = c("--no-manual", additionalCheckArgs), 
+                       build_args = c("--no-multiarch", additionalCheckArgs),
+                       error_on = "warning")
 }
 
 getPackageDependenciesFromGitHub <- function(package) {

diff --git a/extras/Releasing/RunCheckOnAllHadesPackages.R b/extras/Releasing/RunCheckOnAllHadesPackages.R
@@ -9,8 +9,15 @@ saveRDS(prepareForPackageCheck(), "Dependencies.rds")
 dependencies <- readRDS("Dependencies.rds")
 # Skipping Hydra, as renv seems to clash with skeleton renv environments:
 dependencies <- dependencies[dependencies$name != "Hydra", ]
-for (i in 1:nrow(dependencies)) {
-  checkPackage(package = dependencies$name[i], inCran = dependencies$inCran[i])
-
+for (i in 4:nrow(dependencies)) {
+  if (dependencies$name[i] == "PatientLevelPrediction") {
+    # Temp workaround for https://github.com/OHDSI/PatientLevelPrediction/issues/435
+    additionalCheckArgs <- c("--no-build-vignettes", "--ignore-vignettes")
+  } else {
+    additionalCheckArgs <- c()
+  }
+  checkPackage(package = dependencies$name[i], 
+               inCran = dependencies$inCran[i],
+               additionalCheckArgs = additionalCheckArgs)
 }
 unlink("Dependencies.rds")