Develop #587
Merged
Develop #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the checksToExclude by changing the select() to a pull() to make sure we return the vector only rather than a column. Add explicit namespacing and call the library(dplyr) at the top of the commented code. Update the inspect logs code to correct the file.path() argument to include the cdmSourceName only in the .txt file name.
Fix missing pull() and wrong launchLogViewer() file.path() argument fix #568
Add 2 remaining docs pages
Add one new plausibleUnitConceptIds to three ConceptId in version 5.2, 5.3, and 5.4. R script used to add and test included but will not be included with the pull request. Revert "Update Concept_level.csv to include new plausibleUnitConceptIds" This reverts commit 3cd5a52. Update Concept_level.csv to include new plausibleUnitConceptIds Add one new plausibleUnitConceptIds to three ConceptId in version 5.2, 5.3, and 5.4. R script used to add and test included but will not be included with the pull request. Revert "Update Concept_level.csv to include new plausibleUnitConceptIds" This reverts commit 9ab60d1. to revert Revert "to revert" This reverts commit 74453d455b0a88f1b210d7542533181289a29cc3. to revert Revert "to revert" This reverts commit 1ab349678516939e70bce2b2423ca66ac480ee06. Update Concept_level.csv to include new plausibleUnitConceptIds Add one new plausibleUnitConceptIds to three ConceptId in version 5.2, 5.3, and 5.4. R script used to add and test included but will not be included with the pull request.
Update Concept_level.csv to include new plausibleUnitConceptIds
added parameter for checkSeverity, updated docs & vignette
Fix bug in threshold for EPISODE_OBJECT_CONCEPT_ID
Fix small issues
Katy release
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #587 +/- ##
==========================================
- Coverage 85.05% 84.60% -0.45%
==========================================
Files 16 17 +1
Lines 910 942 +32
==========================================
+ Hits 774 797 +23
- Misses 136 145 +9 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v 2.6.2 release