Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for BIGINT person_id #35

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Support for BIGINT person_id #35

wants to merge 2 commits into from

Conversation

schuemie
Copy link
Member

Apologies for creating a PR without an issue. This PR allows the users to specify person IDs that are bigger than a 32-bit integer. Even though the CDM specifies the person_id field is an INT, many databases use a BIGINT to preserve the original patient identifiers.

Because R does not support integers larger than 32-bit, this new code allows the user to provide personIds in any data type that can be converted to character (checked to consists only of numbers). On the database side, these are converted to BIGINT.

(Note that I also updated the HADES GitHub Action to avoid errors due to out-of-date actions)

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5917938) to head (85d195c).

Additional details and impacted files
@@            Coverage Diff            @@
##           develop       #35   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          956      1042   +86     
=========================================
+ Hits           956      1042   +86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant