reexports from omopgenerics

[catalamarti]

No description provided.

[nmercadeb]

I take the lead on this PR :)

[edward-burn]

@nmercadeb @catalamarti do we still need to be using the private dev version of cdmconnector? If no longer needed we can keep the actions as they were and take that out of the description file

[edward-burn]

And why reexport newCohortTable?

[edward-burn]

And I don't like setting eval to false in vignettes. That often leads us to having vignettes with code that doesn't run...

[catalamarti]

@nmercadeb @catalamarti do we still need to be using the private dev version of cdmconnector? If no longer needed we can keep the actions as they were and take that out of the description file

yes, we agreed to remove it, @nmercadeb will take care of it
@edward-burn

[catalamarti]

And I don't like setting eval to false in vignettes. That often leads us to having vignettes with code that doesn't run...

I did that because I was trying to fix it before all the cran releases, now it should be fine to set eval to TRUE again @edward-burn @nmercadeb

[catalamarti]

And why reexport newCohortTable?

I think so, we need to reexport it somewhere so it can be used without calling omopgenerics @edward-burn

[edward-burn]

And why reexport newCohortTable?

I think so, we need to reexport it somewhere so it can be used without calling omopgenerics @edward-burn

Hmmm I'm not sure, I feel like this could potentially be just in omopgenerics as 99% of users won't interact with this

[catalamarti]

agreed with @edward-burn and @nmercadeb that new... functions wont be reexported anywhere

[edward-burn]

This pr currently has 129 files being changed ..... Can @catalamarti / @nmercadeb you please remove:

• changes to github actions (these shouldn't need to be changed)
• addition of a website (the repo is currently private so a public website is not going to work until we make the repo public)

[catalamarti]

done @edward-burn