Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make metadata field optional in StrategusMatcher #317

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Make metadata field optional in StrategusMatcher #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ns/src/main/java/com/odysseusinc/arachne/commons/utils/strategus/StrategusExpression.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

public class StrategusExpression extends CommonObjectJson {

@OptionalField
private Metadata metadata;
private List<SharedResource> sharedResources;
@OptionalField
Expand Down
7 changes: 7 additions & 0 deletions ...hne-commons/src/test/java/com/odysseusinc/arachne/commons/utils/StrategusMatcherTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,13 @@ public void shouldDetectStrategusType() throws IOException {
assertThat(contentType, is(equalTo(CommonFileUtils.TYPE_STRATEGUS_JSON)));
}

@Test
public void shouldDetectStrategusWithoutMetadata() throws IOException {
StrategusMatcher matcher = new StrategusMatcher();
String contentType = matcher.getContentType("strategusStudy.json", getResource("/strategus/strategusStudy2.json"));
assertThat(contentType, is(equalTo(CommonFileUtils.TYPE_STRATEGUS_JSON)));
}

private InputStreamSource getResource(String path) throws IOException {
return new ByteArrayResource(IOUtils.resourceToByteArray(path));
}
Expand Down
3,362 changes: 3,362 additions & 0 deletions arachne-commons/src/test/resources/strategus/strategusStudy2.json
View file
Open in desktop

Large diffs are not rendered by default.