Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 53 #56

Closed
wants to merge 3 commits into from
Closed

Issue 53 #56

wants to merge 3 commits into from

Conversation

schuemie
Copy link
Member

This uses as_record_batch_reader(), thus avoiding the need to copy a dplyr query to an Andromeda object. Addresses issue #53 .

Note: this PR also includes the changes of PR #55 (allowing me to test both locally).

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #56 (20d5799) into develop (09d73a0) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

❗ Current head 20d5799 differs from pull request most recent head 68f9dbe. Consider uploading reports for the commit 68f9dbe to get more accurate results

@@             Coverage Diff             @@
##           develop      #56      +/-   ##
===========================================
- Coverage    82.44%   82.26%   -0.18%     
===========================================
  Files            3        3              
  Lines          262      265       +3     
===========================================
+ Hits           216      218       +2     
- Misses          46       47       +1     
Impacted Files Coverage Δ
R/LoadingSaving.R 92.53% <100.00%> (ø)
R/Operations.R 88.09% <100.00%> (-0.80%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@schuemie
Copy link
Member Author

Maybe not such a good idea. I'm running out of memory for large models

@schuemie
Copy link
Member Author

Damn, also running out of memory with the original code...

@ablack3
Copy link
Collaborator

ablack3 commented May 15, 2023

@schuemie Still interested in merging this PR?

@schuemie
Copy link
Member Author

Since we're putting the arrow implementation on ice for now this PR doesn't make much sense. I'll close it

@schuemie schuemie closed this May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants