Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Arrow backend #40

Merged
merged 50 commits into from
Nov 21, 2022
Merged

Switch to Arrow backend #40

merged 50 commits into from
Nov 21, 2022

Conversation

Adam Black added 30 commits May 3, 2022 17:58
loadAndromeda needs to assign FileSystemDatasets to an andromeda object. The andromeda assignment method must treat FileSystemDataset object as a potential reference to another andromeda table so it makes a copy. When loading we want to disable this behavior by temorarily removing the andromeda class.
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #40 (99fbc44) into develop (24a812d) will decrease coverage by 5.28%.
The diff coverage is 80.00%.

@@             Coverage Diff             @@
##           develop      #40      +/-   ##
===========================================
- Coverage    89.21%   83.93%   -5.29%     
===========================================
  Files            4        3       -1     
  Lines          371      249     -122     
===========================================
- Hits           331      209     -122     
  Misses          40       40              
Impacted Files Coverage Δ
R/Object.R 75.70% <73.56%> (-10.51%) ⬇️
R/Operations.R 88.00% <76.47%> (-1.63%) ⬇️
R/LoadingSaving.R 92.53% <91.52%> (+7.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ablack3
Copy link
Collaborator Author

ablack3 commented Nov 21, 2022

Before this release each Hades maintainer that depends on Andromeda will need to make sure their package works with both the old and new versions. The biggest change is probably how to get rowcounts. An example is OHDSI/FeatureExtraction#179.

@ablack3 ablack3 merged commit af428dd into develop Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant