Ensuring package passes R check even when arrow is not installed. R…

…equired to stay in CRAN.
OHDSI · Jan 19, 2024 · 5d8c553 · 5d8c553
1 parent d0d52e2
commit 5d8c553
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 9 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,16 +1,16 @@
 Package: Andromeda
 Type: Package
 Title: Asynchronous Disk-Based Representation of Massive Data
-Version: 0.6.4
-Date: 2023-11-24
+Version: 0.6.5
+Date: 2024-01-19
 Authors@R: c(
   person("Adam", "Black", , "[email protected]", role = c("aut", "cre")),
   person("Egill", "Fridgeirsson", , "[email protected]", role = c("aut")),
   person("Martijn", "Schuemie", , "[email protected]", role = c("aut")),
   person("Marc A.", "Suchard", , "[email protected]", role = c("aut")),
   person("Observational Health Data Science and Informatics", role = c("cph"))
   )
-Maintainer: Adam Black <black@ohdsi.org>
+Maintainer: Martijn Schuemie <schuemie@ohdsi.org>
 Description: Storing very large data objects on a local drive, while still making it possible to manipulate the data in an efficient manner.
 License: Apache License 2.0
 VignetteBuilder: knitr

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,8 @@
+Andromeda 0.6.5
+===============
+
+- Ensuring package passes R check even when `arrow` is not installed. Required to stay in CRAN.
+
 Andromeda 0.6.4
 ===============
 - Fix a bug causing Andromeda saving not to respect andromeda temp folder

diff --git a/cran-comments.md b/cran-comments.md
@@ -1,7 +1,7 @@
-Andromeda v0.6.4
+Andromeda v0.6.5
 ---
 
-This is a patch release.
+This is a patch release that fixes the error observed on r-devel-linux-x86_64-fedora-clang.
 
 ## Test environments
 * Windows-latest, R-release (Github Actions)

diff --git a/man/Andromeda-package.Rd b/man/Andromeda-package.Rd
diff --git a/tests/testthat/test-object.R b/tests/testthat/test-object.R
@@ -186,8 +186,7 @@ test_that("Get/set Andromeda table/column names works.", {
   close(andr)
 })
 
-test_that("isAndromedaTable", {
-  # sqlite version
+test_that("isAndromedaTable sqlite version", {
   con <- DBI::dbConnect(RSQLite::SQLite(), ":memory:")
   DBI::dbWriteTable(con, "cars", cars)
   db <- dplyr::tbl(con, "cars")
@@ -198,12 +197,16 @@ test_that("isAndromedaTable", {
   class(a$cars)
   expect_true(isAndromedaTable(a$cars))
   expect_true(isAndromedaTable(dplyr::mutate(a$cars, a = 1)))
-
-  # arrow version
+})
+
+test_that("isAndromedaTable arrow version", {
+  skip_if_not_installed("arrow")
+
   path <- tempfile()
   arrow::write_feather(cars, path)
   ds <- arrow::open_dataset(path, format = "feather")
   class(ds)
   expect_true(isAndromedaTable(ds))
   expect_true(isAndromedaTable(dplyr::mutate(ds, a = 1)))
 })
+